[v2] Adjust format of table for accessibility #9547
Merged
+27
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdaily
force-pushed
the
configure-list-table-accessibility
branch
from
64b42e2 to
0732afd
Compare
kdaily
force-pushed
the
cli-accessibility
branch
from
e0f7597 to
c522dbd
Compare
kdaily
force-pushed
the
configure-list-table-accessibility
branch
from
0732afd to
31722f9
Compare
aemous
approved these changes
Sep 19, 2025
Contributor
aemous
left a comment
aemous
left a comment
There was a problem hiding this comment.
LGTM. Would like to see a new-change entry either before this gets merged or before the feature branch gets merged, for each accessibility feature we're releasing.
Member
Author
|
Sounds good for changelogs. I was planning to do that in the feature branch. |
doshitan
added a commit
to navapbc/template-infra
that referenced
this pull request
Oct 6, 2025
A recent change in the AWS CLI[1] updates the output formatting of `aws
configure list`, which breaks the `bin/current-region` script.
In pre-2.31.0 versions the output is:
```
Name Value Type Location
---- ----- ---- --------
profile <not set> None None
access_key ****************ABCD config_file ~/.aws/config
secret_key ****************ABCD config_file ~/.aws/config
region us-west-2 env AWS_DEFAULT_REGION
```
In 2.31.0+ versions the output is:
```
NAME : VALUE : TYPE : LOCATION
profile : <not set> : None : None
access_key : ****************ABCD : config_file : ~/.aws/config
secret_key : ****************ABCD : config_file : ~/.aws/config
region : us-west-2 : env : AWS_DEFAULT_REGION
```
As `aws configure list` does not respect the `--output` flag[2], handle both
formats for now to avoid forcing everyone onto a pre or post 2.31.0 version.
[1] aws/aws-cli#9547
[2] aws/aws-cli#7373 (which in title is for the `aws
configure list-profiles` command, but is also relevant to the `aws configure
list` command and likely any fix there would apply to both)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This change is targeting the
cli-accessibilityfeature branch.Description of changes:
Adjust table output for
aws configure listcommand to remove ASCII art formatting.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.